Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree view tabs on the right are not hidden #48

Open
rschiang opened this issue Oct 9, 2018 · 2 comments · May be fixed by #49
Open

Tree view tabs on the right are not hidden #48

rschiang opened this issue Oct 9, 2018 · 2 comments · May be fixed by #49

Comments

@rschiang
Copy link

rschiang commented Oct 9, 2018 •
edited
Loading

Currently the theme itself hides the first available tab list (ref), which happens to be the one on the left; moving tree view to the right breaks this behavior.

Maybe this could be solved by

  • iterating through .list-inline.tab-bar.inset-panel, or
  • indirectly refer to the parent of .tab[data-type='TreeView']?

Thanks for making the theme! Really love the vibe in City Lights (・ω・)ノ
@noudadrichem
Copy link
Collaborator

I'll take a look at this!

@rschiang rschiang linked a pull request Oct 13, 2018 that will close this issue
Open
@rschiang
Copy link
Author

@noudadrichem @Yummygum I've whipped up a working solution for this! Please see if PR #49 looks good to you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use indirect reference on tree view tab rschiang/city-lights-ui-atom
2 participants
@rschiang @noudadrichem