Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rustc install/update thrue rustup #35

Open
wants to merge 4 commits into
base: testing
Choose a base branch
from

Conversation

rosbeef
Copy link

@rosbeef rosbeef commented Oct 20, 2022

Problem

intallation error due to bad rustc version is rustup correct it .
trying to resolve #34

Solution

install thrue rustup

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

@rosbeef
Copy link
Author

rosbeef commented Oct 20, 2022

Install works ans update should works.
Someone could test?

@rosbeef
Copy link
Author

rosbeef commented Oct 20, 2022

dont know the best way to remove rustc dpkg install

@thardev
Copy link
Collaborator

thardev commented Nov 27, 2022

Hi @rosbeef
I'll try to test it and come back to you 👍
Thank you for the fix!

@thardev
Copy link
Collaborator

thardev commented Nov 28, 2022

!testme

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

@thardev
Copy link
Collaborator

thardev commented Nov 30, 2022

Hi @rosbeef

As you can see the pipeline fails and it complains about some permission issue.
Regarding this fix, could you kindly explain to me a bit better why this is needed? Because in the logs you provided it doesn't seem related. (I don't have experience with Rust)
Thanks!

@rosbeef
Copy link
Author

rosbeef commented Dec 1, 2022

Sorry i'm not so good in developping and i have no time now. I make similar to https://github.com/YunoHost-Apps/synapse_ynh/blob/7a5a9cc4bf652e11c21389981a3419d82eb3f57b/scripts/_common.sh, manualy on my server and it works. Maybe I make a bad test of the update part

@thardev thardev changed the base branch from master to testing February 23, 2023 17:49
# We set all necessary environement variable to create a python virtualenvironnement.
u_arg='u'
set +$u_arg;
source $final_path/bin/activate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this part needed for it to work?

# Install mautrix_telegram in virtualenv

# We set all necessary environement variable to create a python virtualenvironnement.
u_arg='u'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed, with the other set statements, it will pollute the logs of the install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustc is not the rigth version rustup required ?
3 participants