Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change return type to NamedTuple #447

Merged
merged 5 commits into from
Nov 16, 2023
Merged

change return type to NamedTuple #447

merged 5 commits into from
Nov 16, 2023

Conversation

matbesancon
Copy link
Member

@matbesancon matbesancon commented Nov 16, 2023

Improving readability and usability of the returned information for all algorithms.
This change is not breaking since tuple unpacking still works

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef9419a) 84.16% compared to head (c6e6131) 84.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   84.16%   84.16%           
=======================================
  Files          22       22           
  Lines        2766     2766           
=======================================
  Hits         2328     2328           
  Misses        438      438           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matbesancon
Copy link
Member Author

Closes #446

@matbesancon matbesancon merged commit 6aa792f into master Nov 16, 2023
13 checks passed
@matbesancon matbesancon deleted the return-tuple-to-nt branch November 16, 2023 19:58
dhendryc pushed a commit that referenced this pull request Jan 17, 2025
* change return type to nt

* cleanup using

* reimport

* reimport2

* fix random seed on failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant