Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALM and BCFW update #450

Merged
merged 23 commits into from
Jan 15, 2024
Merged

ALM and BCFW update #450

merged 23 commits into from
Jan 15, 2024

Conversation

JannisHal
Copy link
Collaborator

  • adapt ALM and BCFW to using BlockVector
  • isolate Step for blocks in BCFW
  • implement BPCG and FW step for BCFW
  • Update plot sparsity to easier modifications
  • Update ALM handling of initial point

@JannisHal JannisHal marked this pull request as draft November 29, 2023 10:31
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ec70a6a) 84.17% compared to head (a2333a0) 84.58%.

❗ Current head a2333a0 differs from pull request most recent head dfcb14b. Consider uploading reports for the commit dfcb14b to get more accurate results

Files Patch % Lines
src/block_coordinate_algorithms.jl 96.77% 3 Missing ⚠️
src/norm_oracles.jl 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   84.17%   84.58%   +0.40%     
==========================================
  Files          22       22              
  Lines        2767     2847      +80     
==========================================
+ Hits         2329     2408      +79     
- Misses        438      439       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JannisHal JannisHal marked this pull request as ready for review December 4, 2023 17:38
@matbesancon matbesancon merged commit 3fe2b02 into master Jan 15, 2024
11 checks passed
@matbesancon matbesancon deleted the bcfw_update branch January 15, 2024 16:12
pokutta pushed a commit that referenced this pull request Mar 1, 2024
* Update plot_sparsity

* Remove redundant CallbackStateBlockCoordinateMetho

* Isolate update step from BCFW

* SpectraplexLMO add field maxiters

* BCFW allow different stepsize strategies

* Adapt example

* ALM and BCFW for blockvectors

* Small changes

* Small progress on BPCG steps

* FIX BPCG step

* ALM inital point consistency

* Adapt tests

* Add collect for BlockVector

* Remove old CallbackState from Alternating project.

* Format

* Add tests for ALM and BCFW

* Update documentation

* BCFW example

* Add example for BCFW

* Update documentation

* Small documentation fix

* Documentation update
dhendryc pushed a commit that referenced this pull request Jan 17, 2025
* Update plot_sparsity

* Remove redundant CallbackStateBlockCoordinateMetho

* Isolate update step from BCFW

* SpectraplexLMO add field maxiters

* BCFW allow different stepsize strategies

* Adapt example

* ALM and BCFW for blockvectors

* Small changes

* Small progress on BPCG steps

* FIX BPCG step

* ALM inital point consistency

* Adapt tests

* Add collect for BlockVector

* Remove old CallbackState from Alternating project.

* Format

* Add tests for ALM and BCFW

* Update documentation

* BCFW example

* Add example for BCFW

* Update documentation

* Small documentation fix

* Documentation update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants