-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ActiveSetQuadratic and SymmetricXXX #524
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 81.49% 78.95% -2.55%
==========================================
Files 24 24
Lines 3681 3582 -99
==========================================
- Hits 3000 2828 -172
- Misses 681 754 +73 ☔ View full report in Codecov by Sentry. |
I'd prefer |
Sure, how about |
Sold!
…On Fri, Nov 1, 2024, 11:41 Sébastien Designolle ***@***.***> wrote:
Sure, how about ActiveSetQuadraticProductCaching then?
—
Reply to this email directly, view it on GitHub
<#524 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2FDMS66XLW7ZYJM2MV2A3Z6NLEXAVCNFSM6AAAAABQ6PZYSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJRGY3TCOJSGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
* ActiveSetQuadratic -> ActiveSetQuadraticCachedProducts * SymmetricLMO -> SubspaceLMO * reduce -> deflate * SymmetricArray -> SubspaceVector * Cap length of test strings to 50 characters * Suppress verbosity * Fix docstrings for Subspace LMO & Vector * ActiveSetQuadraticCachedProducts -> ActiveSetQuadraticProductCaching
As discussed, I've refactored some structures:
ActiveSetQuadratic
->ActiveSetQuadraticCachedProducts
to make it less general than it looked beforeSymmetricLMO
->SubspaceLMO
andSymmetricArray
->SubspaceVector
to make it more general than it looked before. I need to work on the doc for that before merging. In the process, I changedreduce
intodeflate
to avoid collision with the methodreduce
already defined in julia.As for the tests, the main differences are that the names are now uniform (50 characters long), and that the verbosity is reduced. Now the only messages come from warnings, errors (in Hypatia), and
benchmark_oracles
.