Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ActiveSetQuadratic and SymmetricXXX #524

Merged
merged 8 commits into from
Nov 3, 2024
Merged

Conversation

sebastiendesignolle
Copy link
Collaborator

As discussed, I've refactored some structures:

  • ActiveSetQuadratic -> ActiveSetQuadraticCachedProducts to make it less general than it looked before
  • SymmetricLMO -> SubspaceLMO and SymmetricArray -> SubspaceVector to make it more general than it looked before. I need to work on the doc for that before merging. In the process, I changed reduce into deflate to avoid collision with the method reduce already defined in julia.

As for the tests, the main differences are that the names are now uniform (50 characters long), and that the verbosity is reduced. Now the only messages come from warnings, errors (in Hypatia), and benchmark_oracles.

@sebastiendesignolle sebastiendesignolle changed the title Refactor and clean tests Clean tests and refactor Oct 31, 2024
@sebastiendesignolle sebastiendesignolle changed the title Clean tests and refactor Refactor ActiveSetQuadratic and SymmetricXXX Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 29.82456% with 40 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (8e09471) to head (cda6386).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/types.jl 0.00% 29 Missing ⚠️
src/active_set_quadratic.jl 54.54% 10 Missing ⚠️
src/active_set_quadratic_direct_solve.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   81.49%   78.95%   -2.55%     
==========================================
  Files          24       24              
  Lines        3681     3582      -99     
==========================================
- Hits         3000     2828     -172     
- Misses        681      754      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matbesancon
Copy link
Member

I'd prefer ActiveSetQuadraticCachedProduct without the s, usually singulars are better for types (I know it's multiple product per AS, but it's the method of product caching that we emphasize)

@sebastiendesignolle
Copy link
Collaborator Author

Sure, how about ActiveSetQuadraticProductCaching then?

@matbesancon
Copy link
Member

matbesancon commented Nov 1, 2024 via email

@matbesancon matbesancon merged commit e805431 into master Nov 3, 2024
12 checks passed
@matbesancon matbesancon deleted the refactor branch November 3, 2024 07:45
dhendryc pushed a commit that referenced this pull request Jan 17, 2025
* ActiveSetQuadratic -> ActiveSetQuadraticCachedProducts

* SymmetricLMO -> SubspaceLMO

* reduce -> deflate

* SymmetricArray -> SubspaceVector

* Cap length of test strings to 50 characters

* Suppress verbosity

* Fix docstrings for Subspace LMO & Vector

* ActiveSetQuadraticCachedProducts -> ActiveSetQuadraticProductCaching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants