-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A div node is removed completely (not just suppressed) even with no CSS applied #439
Comments
Hey Jens, thanks for reaching out. I'm not seeing anything in Just Read's code that should delete this element... When I try to create a minimal demo it doesn't remove the text in the Just Read view for me. Does it for you? Do you have any custom domain selectors (the part at the bottom of the Just Read options page) set up? Additionally, if you can save the page as a .html file and share it with me then I can try to test it that way. You can do that through right clicking then clicking "Save as". Or maybe right clicking, clicking "View Page Source" and copying that over to a file and sharing it. |
Hi Zach,
the minimal demo works for me as well.
HTML attached, hope this helps. Do you need more? Screenshot of my Just Read settings? I have the hide-segments.css checked – otherwise Just Read doesn’t work at all, at least with this page and my usual CSS – but I haven’t checked other combinations yet.
Best, Olaf
|
Thanks! I can recreate the issue using the file you sent: https://zachsaucier.com/test.htm After spending a few minutes, I'm not immediately seeing an issue or even a difference with other sections. I'll come back to then when I'm less tired. |
After investigation it is because it is being stripped by Readability.js: the new way of auto-selection that Just Read uses. After going to their GitHub to ask, I found this: mozilla/readability#872 |
So probably a bug in Readibility.js? In fact the removed node resembles a lot of other nodes, I hope they will find something :-) |
Yeah. It's part of the downside of using a third party tool: you inherit some of their bugs |
Looks like it's actually this bug: mozilla/readability#776 |
Describe the bug
In a page (it is one behind a paywall, German SPIEGEL magazine) there is the following node:
This div gets completely removed (missing in Inspector view) by Just read as long as the inner tag is present. This is true even with no css applied at all ("empty" theme). Without tag it does work.
To Reproduce
n/a
Expected behavior
Node should not be removed.
Screenshots
n/a
Please complete the following information:
The text was updated successfully, but these errors were encountered: