Rebased upstream changes and incorperated change requests from review #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zobadaniel
merged commit 9fca6ad
into
ZalozbaDev:unify_hidden_domain_usage_for_recording_and_transcription
zobadaniel
force-pushed
the
unify_hidden_domain_usage_for_recording_and_transcription
branch
from
07365a3
to
9fca6ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebases your changes on top of current upstream main branch.
It also incoorperates the change requests given in the review in: jitsi#1737
Since this is a rebase it cannot be merged from github UI.
I assume the easiest way is to pull from my fork and force push to this fork, which would in turn update the original PR making it mergable into upstream again.