From 2f01e01e78178e1a589800646c55c997767db0f1 Mon Sep 17 00:00:00 2001
From: Conrado Gouvea <conrado@zfnd.org>
Date: Thu, 1 Feb 2024 10:10:20 -0300
Subject: [PATCH] frost-core: expose SigningKey::to/from_scalar() (#601)

* frost-core: expose SigningKey::to/from_scalar()

* Update frost-core/CHANGELOG.md
---
 frost-core/CHANGELOG.md       | 2 ++
 frost-core/src/signing_key.rs | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/frost-core/CHANGELOG.md b/frost-core/CHANGELOG.md
index 801d450a..ebff51b8 100644
--- a/frost-core/CHANGELOG.md
+++ b/frost-core/CHANGELOG.md
@@ -4,6 +4,8 @@ Entries are listed in reverse chronological order.
 
 ## Unreleased
 
+* Exposed the `SigningKey::from_scalar()` and `to_scalar()` methods. This
+  helps interoperability with other implementations.
 
 ## Released
 
diff --git a/frost-core/src/signing_key.rs b/frost-core/src/signing_key.rs
index 6d165835..26d812f2 100644
--- a/frost-core/src/signing_key.rs
+++ b/frost-core/src/signing_key.rs
@@ -58,7 +58,6 @@ where
     }
 
     /// Creates a SigningKey from a scalar.
-    #[cfg(feature = "internals")]
     pub fn from_scalar(
         scalar: <<<C as Ciphersuite>::Group as Group>::Field as Field>::Scalar,
     ) -> Self {
@@ -66,7 +65,6 @@ where
     }
 
     /// Return the underlying scalar.
-    #[cfg(feature = "internals")]
     pub fn to_scalar(self) -> <<<C as Ciphersuite>::Group as Group>::Field as Field>::Scalar {
         self.scalar
     }