Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frost-core): add (de)serialization for VerifiableSecretSharingSharingSharingCommitment #878

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(frost-core): add (de)serialization for VerifiableSecretSharingSharingSharingCommitment #878

wants to merge 6 commits into from
+293 −1

Conversation

StackOverflowExcept1on
Copy link
Contributor

Resolves #870
@conradoplg

@mpguerra mpguerra requested a review from conradoplg February 19, 2025 12:12
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (5f4ac6e) to head (9ffdc20).
Report is 105 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
+ Coverage   82.18%   82.95%   +0.77%     
==========================================
  Files          31       41      +10     
  Lines        3188     4406    +1218     
==========================================
+ Hits         2620     3655    +1035     
- Misses        568      751     +183

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

conradoplg
conradoplg requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would you mind adding tests? Otherwise we can add them later.

StackOverflowExcept1on and others added 2 commits February 19, 2025 17:52
@StackOverflowExcept1on @conradoplg
Update frost-core/src/keys.rs
40cd1b9 
Co-authored-by: Conrado Gouvea <[email protected]>
@StackOverflowExcept1on @conradoplg
Update frost-core/src/keys.rs
5250dd3 
Co-authored-by: Conrado Gouvea <[email protected]>
@StackOverflowExcept1on
Copy link
Contributor Author

I'll add tests and maybe update the changelog in the next 3 days.

@StackOverflowExcept1on
Copy link
Contributor Author

@conradoplg I added tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg conradoplg requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a method to serialize the whole VerifiableSecretSharingSharingCommitment<C>.
2 participants
@StackOverflowExcept1on @conradoplg