From 59f391f3dc6345c1230cd3727d317387c7939294 Mon Sep 17 00:00:00 2001 From: Conrado Gouvea Date: Fri, 18 Aug 2023 21:46:15 -0300 Subject: [PATCH 1/2] update spec links --- frost-core/src/frost.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frost-core/src/frost.rs b/frost-core/src/frost.rs index fe9d8a2e..8572a975 100644 --- a/frost-core/src/frost.rs +++ b/frost-core/src/frost.rs @@ -97,7 +97,7 @@ where /// [`compute_binding_factors`] in the spec /// -/// [`compute_binding_factors`]: https://www.ietf.org/archive/id/draft-irtf-cfrg-frost-10.html#section-4.4 +/// [`compute_binding_factors`]: https://www.ietf.org/archive/id/draft-irtf-cfrg-frost-14.html#section-4.4 #[cfg_attr(feature = "internals", visibility::make(pub))] pub(crate) fn compute_binding_factor_list( signing_package: &SigningPackage, @@ -323,7 +323,7 @@ where /// /// Implements [`compute_group_commitment`] from the spec. /// -/// [`compute_group_commitment`]: https://www.ietf.org/archive/id/draft-irtf-cfrg-frost-10.html#section-4.5 +/// [`compute_group_commitment`]: https://www.ietf.org/archive/id/draft-irtf-cfrg-frost-14.html#section-4.5 #[cfg_attr(feature = "internals", visibility::make(pub))] fn compute_group_commitment( signing_package: &SigningPackage, From 16407bf68d613f013f685787f4be0944e5c468ab Mon Sep 17 00:00:00 2001 From: Conrado Gouvea Date: Fri, 18 Aug 2023 23:56:13 -0300 Subject: [PATCH 2/2] don't import unneeded dependencies when not required --- frost-core/Cargo.toml | 8 ++++++-- frost-ed25519/Cargo.toml | 5 +++-- frost-ed448/Cargo.toml | 3 ++- frost-p256/Cargo.toml | 3 ++- frost-ristretto255/Cargo.toml | 3 ++- frost-secp256k1/Cargo.toml | 3 ++- 6 files changed, 17 insertions(+), 8 deletions(-) diff --git a/frost-core/Cargo.toml b/frost-core/Cargo.toml index e3d00f52..b7cf0aa6 100644 --- a/frost-core/Cargo.toml +++ b/frost-core/Cargo.toml @@ -5,7 +5,11 @@ edition = "2021" # - Update CHANGELOG.md # - Create git tag. version = "0.6.0" -authors = ["Deirdre Connolly ", "Chelsea Komlo ", "Conrado Gouvea "] +authors = [ + "Deirdre Connolly ", + "Chelsea Komlo ", + "Conrado Gouvea ", +] readme = "README.md" license = "MIT OR Apache-2.0" repository = "https://github.com/ZcashFoundation/frost" @@ -20,7 +24,7 @@ features = ["nightly"] byteorder = "1.4" debugless-unwrap = "0.0.4" derive-getters = "0.3.0" -hex = { version = "0.4.3", features = ["serde"] } +hex = "0.4.3" rand_core = "0.6" serde = { version = "1.0.160", features = ["derive"], optional = true } serdect = { version = "0.2.0", optional = true } diff --git a/frost-ed25519/Cargo.toml b/frost-ed25519/Cargo.toml index 711c2df6..c45a4443 100644 --- a/frost-ed25519/Cargo.toml +++ b/frost-ed25519/Cargo.toml @@ -22,13 +22,14 @@ description = "A Schnorr signature scheme over Ed25519 that supports FROST." features = ["nightly"] [dependencies] -curve25519-dalek = { version = "=4.0.0", features = ["serde", "rand_core"] } -frost-core = { path = "../frost-core", version = "0.6.0", features = ["test-impl"] } +curve25519-dalek = { version = "=4.0.0", features = ["rand_core"] } +frost-core = { path = "../frost-core", version = "0.6.0" } rand_core = "0.6" sha2 = "0.10.2" [dev-dependencies] criterion = "0.5" +frost-core = { path = "../frost-core", version = "0.6.0", features = ["test-impl"] } frost-rerandomized = { path = "../frost-rerandomized", version = "0.6.0", features = ["test-impl"] } ed25519-dalek = "2.0.0" hex = "0.4.3" diff --git a/frost-ed448/Cargo.toml b/frost-ed448/Cargo.toml index 01d0a486..af918d14 100644 --- a/frost-ed448/Cargo.toml +++ b/frost-ed448/Cargo.toml @@ -22,12 +22,13 @@ features = ["nightly"] [dependencies] ed448-goldilocks = { version = "0.9.0" } -frost-core = { path = "../frost-core", version = "0.6.0", features = ["test-impl"] } +frost-core = { path = "../frost-core", version = "0.6.0" } rand_core = "0.6" sha3 = "0.10.6" [dev-dependencies] criterion = "0.5" +frost-core = { path = "../frost-core", version = "0.6.0", features = ["test-impl"] } frost-rerandomized = { path = "../frost-rerandomized", version = "0.6.0", features = ["test-impl"] } lazy_static = "1.4" hex = "0.4.3" diff --git a/frost-p256/Cargo.toml b/frost-p256/Cargo.toml index a5641ba9..d5f9d3a8 100644 --- a/frost-p256/Cargo.toml +++ b/frost-p256/Cargo.toml @@ -23,12 +23,13 @@ features = ["nightly"] [dependencies] p256 = { version = "0.13.0", features = ["hash2curve"] } -frost-core = { path = "../frost-core", version = "0.6.0", features = ["test-impl"] } +frost-core = { path = "../frost-core", version = "0.6.0" } rand_core = "0.6" sha2 = "0.10.2" [dev-dependencies] criterion = "0.5" +frost-core = { path = "../frost-core", version = "0.6.0", features = ["test-impl"] } frost-rerandomized = { path = "../frost-rerandomized", version = "0.6.0", features = ["test-impl"] } hex = "0.4.3" lazy_static = "1.4" diff --git a/frost-ristretto255/Cargo.toml b/frost-ristretto255/Cargo.toml index 66dbffde..31f87a65 100644 --- a/frost-ristretto255/Cargo.toml +++ b/frost-ristretto255/Cargo.toml @@ -19,12 +19,13 @@ features = ["nightly"] [dependencies] curve25519-dalek = { version = "=4.0.0", features = ["serde", "rand_core"] } -frost-core = { path = "../frost-core", version = "0.6.0", features = ["test-impl"] } +frost-core = { path = "../frost-core", version = "0.6.0" } rand_core = "0.6" sha2 = "0.10.2" [dev-dependencies] criterion = { version = "0.5", features = ["html_reports"] } +frost-core = { path = "../frost-core", version = "0.6.0", features = ["test-impl"] } frost-rerandomized = { path = "../frost-rerandomized", version = "0.6.0", features = ["test-impl"] } hex = "0.4.3" lazy_static = "1.4" diff --git a/frost-secp256k1/Cargo.toml b/frost-secp256k1/Cargo.toml index 4b7bae88..82dbfc02 100644 --- a/frost-secp256k1/Cargo.toml +++ b/frost-secp256k1/Cargo.toml @@ -21,13 +21,14 @@ description = "A Schnorr signature scheme over the secp256k1 curve that supports features = ["nightly"] [dependencies] -frost-core = { path = "../frost-core", version = "0.6.0", features = ["test-impl"] } +frost-core = { path = "../frost-core", version = "0.6.0" } k256 = { version = "0.13.0", features = ["arithmetic", "expose-field", "hash2curve"] } rand_core = "0.6" sha2 = "0.10.2" [dev-dependencies] criterion = "0.5" +frost-core = { path = "../frost-core", version = "0.6.0", features = ["test-impl"] } frost-rerandomized = { path = "../frost-rerandomized", version = "0.6.0", features = ["test-impl"] } hex = "0.4.3" lazy_static = "1.4"