Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in documentation files #774

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

leopardracer
Copy link
Contributor

This pull request contains changes to improve clarity, correctness and structure.

Description correction:
Corrected "needs an unique" to "needs a unique".
Corrected "If there is not" to "If there is no".

Please review the changes and let me know if any additional changes are needed.

@conradoplg
Copy link
Contributor

All dkg.md are generated from the frost-ristretto255 one. Would you mind updating them all?

@leopardracer
Copy link
Contributor Author

@conradoplg I checked for typos and corrected them where it was possible.

frost-p256/dkg.md Outdated Show resolved Hide resolved
@leopardracer
Copy link
Contributor Author

@conradoplg Hi! Apologies for the inconvenience. I just wanted to check if there’s anything I can improve in my pull request. Please feel free to ask any questions or let me know if any changes are needed to meet the project's merge requirements. I’m happy to make adjustments!

mergify bot added a commit that referenced this pull request Nov 19, 2024
@mergify mergify bot merged commit 94c0042 into ZcashFoundation:main Nov 19, 2024
16 of 17 checks passed
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.71%. Comparing base (5f4ac6e) to head (9e8990f).
Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
- Coverage   82.18%   81.71%   -0.47%     
==========================================
  Files          31       34       +3     
  Lines        3188     3331     +143     
==========================================
+ Hits         2620     2722     +102     
- Misses        568      609      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mpguerra
Copy link
Contributor

@conradoplg Hi! Apologies for the inconvenience. I just wanted to check if there’s anything I can improve in my pull request. Please feel free to ask any questions or let me know if any changes are needed to meet the project's merge requirements. I’m happy to make adjustments!

All good, thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants