Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frost: incorporate recent fixes; add into_positive_y() to redpallas #68

Merged
merged 8 commits into from
Oct 3, 2023

Conversation

conradoplg
Copy link
Contributor

@conradoplg conradoplg commented Jul 21, 2023

A bunch of improvements happened in the frost repo that we forgot to incorporate here, mainly some re-exports that were missing; and the RTS re-exports. This PR adds those.

This also adds a into_positive_y() method to KeyPackage and PublicKeyPackage via a trait. This is required in RedPallas by the Zcash specification, which mandates that spend validating keys have positive Y coordinates.

The MSRV test was changed to not use all-features; some FROST code does not follow the MSRV. Since frost is non-default I think this is OK until we address it (or bump MSRV).

And finally, this also changes CI due to a MSRV issue (the latest blake2b_simd MSRV is 1.66, but that should not block us, since users can use lower version of the dependency. And adding a restriction to Cargo.toml seems bad practice. So the workaround is to commit the lockfile.

  • Lockfile is now comitted
  • CI was changed to update to latest dependencies in the nightly test

Sorry for mixing different things in the same PR. This PR is required by the demo.

@conradoplg conradoplg marked this pull request as draft July 21, 2023 17:38
@conradoplg conradoplg changed the title frost: expose dkg module frost: incorporate recent fixes; add into_positive_y() to redpallas Jul 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

Merging #68 (1293491) into main (b1bbad7) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   84.77%   84.73%   -0.05%     
==========================================
  Files          12       12              
  Lines         762      760       -2     
==========================================
- Hits          646      644       -2     
  Misses        116      116              

@conradoplg conradoplg marked this pull request as ready for review July 22, 2023 01:07
@mpguerra mpguerra requested a review from natalieesk September 12, 2023 19:33
Copy link

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests needed to be added but that will be done in a separate issue

@natalieesk natalieesk merged commit ac52400 into main Oct 3, 2023
4 checks passed
@natalieesk natalieesk deleted the expose-dkg branch October 3, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants