-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frost: incorporate recent fixes; add into_positive_y() to redpallas #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
changed the title
frost: expose dkg module
frost: incorporate recent fixes; add into_positive_y() to redpallas
Jul 22, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
- Coverage 84.77% 84.73% -0.05%
==========================================
Files 12 12
Lines 762 760 -2
==========================================
- Hits 646 644 -2
Misses 116 116 |
conradoplg
force-pushed
the
expose-dkg
branch
from
September 14, 2023 17:21
19ec4a3
to
1293491
Compare
This was referenced Sep 29, 2023
Merged
natalieesk
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests needed to be added but that will be done in a separate issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of improvements happened in the
frost
repo that we forgot to incorporate here, mainly some re-exports that were missing; and the RTS re-exports. This PR adds those.This also adds a
into_positive_y()
method toKeyPackage
andPublicKeyPackage
via a trait. This is required in RedPallas by the Zcash specification, which mandates that spend validating keys have positive Y coordinates.The MSRV test was changed to not use all-features; some FROST code does not follow the MSRV. Since
frost
is non-default I think this is OK until we address it (or bump MSRV).And finally, this also changes CI due to a MSRV issue (the latest blake2b_simd MSRV is 1.66, but that should not block us, since users can use lower version of the dependency. And adding a restriction to Cargo.toml seems bad practice. So the workaround is to commit the lockfile.
Sorry for mixing different things in the same PR. This PR is required by the demo.