Remove indices #121
Closed
Remove indices #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failure is because of a previously unstable docs feature that has been deprecated, I can fix that
|
The previous implementation was using an "index" to refer to a particular FROST participant. These references are handled in a different manner now, so they were changed to "id"s (identifiers).
upbqdn
commented
Aug 1, 2021
There was a problem hiding this comment.
It will be better to finish this PR once #108 is merged.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @dconnolly and @oxarbitrage)
|
Closing this since it's oudated, FROST code is now in https://github.com/ZcashFoundation/frost/pulls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was using an
indexto refer to a particular FROSTparticipant. These references are handled in a different manner now, so they
were changed to
ids (identifiers).Resolves #116 .
This change is