Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cache Sprout tree roots in tests #8741

Merged
merged 1 commit into from
Aug 3, 2024
Merged

fix: Cache Sprout tree roots in tests #8741

merged 1 commit into from
Aug 3, 2024

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Aug 3, 2024

Motivation

Close #8739.

Solution

  • Cache the roots of Sprout trees before storing the trees in the state in tests.

Tests

Tests in #8729 should pass after rebasing it atop this PR.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@upbqdn
Store Sprout trees with cached roots
f70f477 
Zebra's database expects all stored trees to have their roots cached in
them.
@upbqdn upbqdn added C-bug Category: This is a bug C-testing Category: These are tests A-state Area: State / database changes P-Critical 🚑 labels Aug 3, 2024
@upbqdn upbqdn self-assigned this Aug 3, 2024
@upbqdn upbqdn requested a review from a team as a code owner August 3, 2024 21:01
@upbqdn upbqdn requested review from arya2 and removed request for a team August 3, 2024 21:01
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Aug 3, 2024
@upbqdn upbqdn requested a review from oxarbitrage August 3, 2024 21:04
@mergify mergify bot merged commit 16168d7 into main Aug 3, 2024
136 checks passed
@mergify mergify bot deleted the fix-populating-test-db branch August 3, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage

Assignees

@upbqdn upbqdn

Labels
A-state Area: State / database changes C-bug Category: This is a bug C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Critical 🚑
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests populate the state with Sprout trees without cached roots
2 participants
@upbqdn @arya2