Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: audio #79

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: audio #79

wants to merge 1 commit into from

Conversation

fermionboson101
Copy link

@fermionboson101 fermionboson101 commented Dec 9, 2023 •
edited
Loading

  1. exposed new API for audio
  2. added new audio bitrate (128K), works for both audio and video conversion.

@abskrj
Copy link
Member

abskrj commented Dec 9, 2023

@fermionboson101 pls check the deepsource check

abskrj
abskrj reviewed Dec 9, 2023
View reviewed changes
constants/ffmpeg.go
Video5M
Video3M
Video1M
Video800K
Video400K
)

const (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep this const in the upper one, else iota value starts at 0, so ImagePng and Audio192K will have same value

controllers/process.go
return
}

log.Println("request", request)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: printing request twice

constants/ffmpeg.go
@@ -52,6 +56,7 @@ const Scale = "scale"

var AudioFileTypeMap = map[FILE_TYPE]string{
Audio192K: "_audio192k.m4a",
Audio128K: "_audio128k.m4a",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m4a is supported only for dash protocol

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let discuss on this

service/dash.go

wg.Add(len(constants.AudioFileTypeMap))

go generateAudioFiles(targetFile, outputPath, &wg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets connect once to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abskrj abskrj abskrj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fermionboson101 @abskrj