int-679 code review feedbacks

ZeroGachis · Apr 24, 2024 · 1aed1e9 · 1aed1e9
1 parent da4d895
commit 1aed1e9
Showing 1 changed file with 26 additions and 24 deletions.
diff --git a/magicparse/schema.py b/magicparse/schema.py
@@ -73,30 +73,32 @@ def stream_parse(
 
         for row in reader:
             row_number += 1
-            if any(row):
-                errors = []
-                item = {}
-                for field in self.fields:
-                    try:
-                        value = field.read_value(row)
-                    except Exception as exc:
-                        errors.append({"row-number": row_number, **field.error(exc)})
-                        continue
-
-                    item[field.key] = value
-
-                for computed_field in self.computed_fields:
-                    try:
-                        value = computed_field.read_value(item)
-                    except Exception as exc:
-                        errors.append(
-                            {"row-number": row_number, **computed_field.error(exc)}
-                        )
-                        continue
-
-                    item[computed_field.key] = value
-
-                yield item, errors
+            if not any(row):
+                continue
+
+            errors = []
+            item = {}
+            for field in self.fields:
+                try:
+                    value = field.read_value(row)
+                except Exception as exc:
+                    errors.append({"row-number": row_number, **field.error(exc)})
+                    continue
+
+                item[field.key] = value
+
+            for computed_field in self.computed_fields:
+                try:
+                    value = computed_field.read_value(item)
+                except Exception as exc:
+                    errors.append(
+                        {"row-number": row_number, **computed_field.error(exc)}
+                    )
+                    continue
+
+                item[computed_field.key] = value
+
+            yield item, errors
 
 
 class CsvSchema(Schema):