Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy ProductFootprint model #23

Open
4 tasks
JohnVonNeumann opened this issue Mar 16, 2024 · 0 comments
Open
4 tasks

tidy ProductFootprint model #23

JohnVonNeumann opened this issue Mar 16, 2024 · 0 comments
Assignees
Labels
improvement Stuff that needs to be improved

Comments

@JohnVonNeumann
Copy link
Member

The ProductFootprint model was the first model that was added, and it was done in a fairly POC friendly manner to just get it out and done, as a result, it is Not Good. It needs to be cleaned up.

  • snake_case the field names
  • rename it from ProductFootprint to ProductFootprintModel to keep the new standard, so it's easy to differentiate between the PFSchema and the soon to come ProductFootprint domain object for internal use and translation.
  • massively overhaul the test suite, it just needs more
  • go through the model itself and ensure that mandatory data fields are set to required=True, even the id field isnt currently mandatory

out of scope:
egregious levels of normalisation, if it makes sense and is quick, then do it, but it does not need to be entirely broken out yet.

@JohnVonNeumann JohnVonNeumann added the improvement Stuff that needs to be improved label Mar 16, 2024
@JohnVonNeumann JohnVonNeumann added this to the Alpha - v2.0.1 milestone Mar 16, 2024
@JohnVonNeumann JohnVonNeumann self-assigned this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Stuff that needs to be improved
Projects
None yet
Development

No branches or pull requests

1 participant