Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carbon footprint scope fields are out of alignment, not populating correctly #26

Open
2 of 3 tasks
JohnVonNeumann opened this issue Mar 19, 2024 · 0 comments
Open
2 of 3 tasks
Assignees
Labels
bug Something isn't working

Comments

@JohnVonNeumann
Copy link
Member

JohnVonNeumann commented Mar 19, 2024

Fields that are related to this part of the spec, https://wbcsd.github.io/tr/2023/data-exchange-protocol-20231207/#dt-carbonfootprint-scope, are not implemented correctly. The schema needs to be adjusted to include them as possible options, according to the requirements docs, as well as adjustments made on the database end as well. along with then ensuring that None fields are not rendered by the api, and example of this can be seen in the code somewhere.

  • add remaining scope related fields to carbon footprint schema
  • add remaining scope related fields to carbon footprint database model
  • ensure that None valued fields are not rendered by the API

An interesting thought here is that I think this is a good issue to start the introduction of the business domain model layer, as this issue of deciding whether something is global, regional etc, does not belong anywhere else, and it's better to represent such core logic without it being tightly bound to a technology such as Pydantic or SQLAlchemy

@JohnVonNeumann JohnVonNeumann added the bug Something isn't working label Mar 19, 2024
@JohnVonNeumann JohnVonNeumann added this to the Alpha - v2.0.1 milestone Mar 19, 2024
@JohnVonNeumann JohnVonNeumann self-assigned this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant