Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon not displayed when deploying a library via Nuget #143

Closed
georgtauber-durst opened this issue Nov 4, 2024 · 2 comments
Closed

Icon not displayed when deploying a library via Nuget #143

georgtauber-durst opened this issue Nov 4, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@georgtauber-durst
Copy link

georgtauber-durst commented Nov 4, 2024

In combination with a NuGet-Server the Icon is not displayed.

The icon is integrated according to the official Nuget reference (https://learn.microsoft.com/en-us/nuget/reference/nuspec#icon)

e.g.

<package>
  <metadata>
    ...
    <icon>images\icon.png</icon>
    ...
  </metadata>
  <files>
    ...
    <file src="..\icon.png" target="images\" />
    ...
  </files>
</package>
@iadonkey iadonkey added the enhancement New feature or request label Nov 4, 2024
@seehma
Copy link
Contributor

seehma commented Nov 5, 2024

Currently Twinpack only supports iconUrl. We have registered your request for the icon tag (as described in the nuspec documentation) as feature request and will reach out back to this issue when its implemented.

@iadonkey
Copy link
Contributor

iadonkey commented Dec 7, 2024

Good news, starting with the next major release of Twinpack (version 1.2.x) the icon tag will be supported as it is documented in the official NuGet "nuspec reference"

Screenshot_20241207_202106

Since this is not critical issue, the feature is not backported into Twinpack 1.0.x and we hope to do the release of Twinpack 1.2 in January 2025. Stay tuned and thank you for the feature request

@iadonkey iadonkey closed this as completed Dec 7, 2024
@iadonkey iadonkey self-assigned this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants