Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onClickItem event #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

GreenRover
Copy link

I add the onClickItem event.
This is an requirement of one of my project.
where i have complex items in tree. And open onClick on the right halfe of the screen an bigger editing formular. There for is the href not very usefull.

You not need to add mentioned me as contributor.

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #54 into master will decrease coverage by 0.34%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   40.98%   40.63%   -0.35%     
==========================================
  Files           9        9              
  Lines         405      438      +33     
  Branches       37       40       +3     
==========================================
+ Hits          166      178      +12     
- Misses        235      256      +21     
  Partials        4        4
Impacted Files Coverage Δ
...x-tree-dnd-parent/ngx-tree-dnd-parent.component.ts 33.69% <33.33%> (-0.04%) ⬇️
...jects/ngx-tree-dnd/src/lib/ngx-tree-dnd.service.ts 35.6% <33.33%> (-0.24%) ⬇️
...ee-dnd-children/ngx-tree-dnd-children.component.ts 31.57% <50%> (+2.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f88b1...5747498. Read the comment docs.

@GreenRover
Copy link
Author

@Zicrael Hi is this pull request acceptable for you?

by add events for mouseEnter and mouseLeave
@andy008
Copy link

andy008 commented Jun 3, 2021

I've just included this code and it works nicely. Would be good to see it merged. Thank you @GreenRover :-)

@CrackerakiUA
Copy link

tested on npm i --save https://github.com/GreenRover/ngx-tree-dnd.git#dev-branch and on npm i --save https://github.com/GreenRover/ngx-tree-dnd.git. On both event is not fired

<lib-ngx-tree-component (onClickItem)="onClickItem($event)"></lib-ngx-tree-component>

@Zicrael this is really helpful feature, would be nice to have it under plugin. @GreenRover Could you also update readme?

@GreenRover
Copy link
Author

@CrackerakiUA sorry dont like to invest in a dead project, please see how old this pr is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants