Improve performance #10
Conversation
| @@ -11,122 +11,108 @@ | |||
| // @grant none | |||
| // ==/UserScript== | |||
|
|
|||
| (function() { | |||
There was a problem hiding this comment.
I'd thought enclosing the whole thing in a function was important to stop the scope leaking out, but I could be wrong there. Tampermonkey includes it in the template for a new script.
There was a problem hiding this comment.
Tampermonkey uses a very old template. In any browser used today, there is no need to use IEEE functions.
|
|
||
| const playerIsFullscreen = () => { | ||
| const player = document.querySelector('ytd-player') | ||
| debugPlayerSize(player) |
There was a problem hiding this comment.
Without any explanation as to how performance is improved, I assume you mean it's by not having to log the player size debugging? I never noticed an impact. And it'd be helpful information to supply when reporting an issue, so I'd like to leave it in. If you're concerned about it, a more useful change would be to make it toggleable via config.
There was a problem hiding this comment.
console.log is useful when you are actively debugging the code. I don't think it is useful to print information and fill the dev console from these messages.
|
|
||
| const isWatchVideoPage = () => window.location.pathname == "/watch" | ||
| const isWatchVideoPage = () => window.location.pathname === "/watch" |
There was a problem hiding this comment.
What's the necessity for all the triple equals?
There was a problem hiding this comment.
=== means that the type of the left-hand side is the same as the type of the right-hand side.
Fixes #9