Google Shopping default Image & PHP 5.4

[Amadeco]

Good evening,

First at all, congratulations to make this module compatible with the new Google Shopping Api.
Very useful & hard work.

I just want to warn you about google shopping default image attribute which is not filled by default, I think it will be better to set this attribute check for the first image. When you have many products, it simply impossible to configure this parameter one by one.

Also, I do not understand the use of the shortcut [] to create array, you make your module less accessible.

Thank you for your hard work.

Cheers.

[SchumacherFM]

Good points! Thanks!

PHP 5.3 is End of Life and PHP 5.4 supports short array syntax. Time to move on.

[Amadeco]

I am not very fan about alternative/shortcut syntax.

I would like to ask you something also, Even when I comment

    $url = $product->getGoogleShoppingImage();
    if ($url && $url != "no_selection") {

        $url = Mage::getModel('catalog/product_media_config')->getMediaUrl($product->getGoogleShoppingImage());
        $shoppingProduct->setImageLink($url);
        return $shoppingProduct;
    }

Google Merchant do not receive the image link.
It not integrate with the others attributes.
Have you a lead ?

A point that could be good is to integrate the shipping method (by default) directly in the API.

Thank you.

[SchumacherFM]

To be honest: no idea :-( But if you can figure it out and send me a pull request I'm happy to merge it in!

[Amadeco]

Hello,

That is a misunderstanding of mine. The normal behaviour of Google Merchant is to download the image after the product is valid.

It is interesting to implement additionnal image (more queries) ?

$i = 0; 
            foreach ($product->getMediaGalleryImages() as $image) {
                if ($i++ != 1) {
                    $shoppingProduct->setAdditionalImageLink($image->getUrl());
                }
            }

[SchumacherFM]

Will take care of that. May take a while :-(