Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for caption outside of image #4

Open
MaggiWuerze opened this issue Sep 12, 2018 · 8 comments
Open

Option for caption outside of image #4

MaggiWuerze opened this issue Sep 12, 2018 · 8 comments

Comments

@MaggiWuerze
Copy link

MaggiWuerze commented Sep 12, 2018

could you add an option to display the caption UNDER the image. This way it would not obscure the image when wrapped. I managed to do it via chrome dev console simply by setting the following properties of the surrounding div:

  • position: initial <-- instead of absolute so the captions top sticks to the lower edge of the image
  • overflow-y: auto; <-- so very long captions dont leave the screen and get a scrollbar if needed
  • height: fit-content <--| this would need some tinkering or maybe an additional option. i ran with 100px.
  • max-height:???px; <--|

image

image

@DanielBiegler
Copy link

This I'd love as well. I can take a look at it later. Are you still interested in this @MaggiWuerze ?

@MaggiWuerze
Copy link
Author

Yeah definitely, i can't live without this extension and this has bugged me for some time. Thanks for looking into it

@MaggiWuerze
Copy link
Author

is there any progress regarding this feature?

@DanielBiegler
Copy link

DanielBiegler commented Jan 23, 2019

Oh hey there, thanks for reminding me. I just spent some time to implement it here: https://github.com/DanielBiegler/chrome-extension-imagus/tree/feature/caption-under-media-with-wordwrap

I guess before this should be merged, the options page should be edited as well. I commited only twice, check it out.

Got to go now, will check it out later.

@MaggiWuerze
Copy link
Author

really nice, looks good to me.
Are you planning to give an option for max-height when you touch the options page??

@DanielBiegler
Copy link

Yeah one should also keep in mind the options for Captions in the imagus settings. There are options for the position. I hardcoded it to be on the bottom, it would be way better to respect the optionspage. I might check it out later but would be cool if you wanna help out.

@MaggiWuerze
Copy link
Author

i'll have a look at how it could be positioned

@MaggiWuerze
Copy link
Author

MaggiWuerze commented Feb 6, 2019

ok, it seems if you just switch the order of the <img> and the <div> containing the caption when the caption should be displayed on top and set the captions position to initial (as you already did) it works pretty flawless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants