added subtitles with languages such as Chinese, Japanese, etc. cannot be fully displayed

[stonemason10]

Expected Behavior

Add subtitles normally

Actual Behavior

After upgrading to version 2.1.1 of Moviepy, it is not possible to wrap subtitles when adding them. Multiple subtitles can only display one line, and any excess will be truncated.

Steps to Reproduce the Problem

Specifications

• Python Version: 3.11
• MoviePy Version: 2.1.1
• Platform Name: windows
• Platform Version: windows10

[Implosiv3]

Could you please provide some code (the code you used and failed is ok) to be able to check and investigate about that? I've not used the subtitles functionality yet and I could try with your code. Thank you.

[stonemason10]

Could you please provide some code (the code you used and failed is ok) to be able to check and investigate about that? I've not used the subtitles functionality yet and I could try with your code. Thank you.

def add_subtitles_to_video_textclip(video_clip, srt_path, subtitle_config, video_path):
    """Add subtitles to video using moviepy's TextClip"""
    video_filename = os.path.basename(video_path)
    logging.info(f"Adding subtitles to video using moviepy's TextClip: {video_filename}")
    try:
        subtitles = pysrt.open(srt_path)
        subtitle_clips = []
        
        video_width, video_height = video_clip.w, video_clip.h
        subtitle_width = int(video_width * subtitle_config['width_ratio'])
        
        for subtitle in subtitles:
            start_time = subtitle.start.ordinal / 1000.0
            end_time = subtitle.end.ordinal / 1000.0
            text = subtitle.text
            
            # Create TextClip, set size to wrap text automatically
            text_clip = TextClip(
                text=text,
                font=subtitle_config['font_path'],
                font_size=subtitle_config['font_size'],
                color=subtitle_config['color'],
                size=(subtitle_width, None),
                method="caption",
                stroke_width=subtitle_config['stroke_width'],
                stroke_color=subtitle_config['stroke_color'],
                bg_color=None,
                transparent=True,
                interline=subtitle_config['interline'],
                text_align="center",
                horizontal_align="center",
            )
            
            # Get the actual height of the subtitle
            subtitle_height = text_clip.h 
            
            # Calculate available height
            margin_pixels = video_height * subtitle_config['margin_bottom']
            available_height = video_height - margin_pixels
            
            # If subtitle height exceeds available height, adjust position upwards
            if subtitle_height > available_height:
                y_position = video_height - margin_pixels - subtitle_height
                if y_position < 0:
                    y_position = 0
            else:
                y_position = video_height - margin_pixels - subtitle_height
                if y_position < 0:
                    y_position = 0
            
            # Set subtitle position
            text_clip = text_clip.with_position(('center', y_position))
            
            # Set subtitle duration
            text_clip = text_clip.with_duration(end_time - start_time).with_start(start_time)
            subtitle_clips.append(text_clip)
        
        # Combine video and subtitles, with subtitles on top
        final_clip = CompositeVideoClip([video_clip] + subtitle_clips)
        return final_clip
    except Exception as e:
        logging.error(f"An error occurred while adding subtitles to video {video_filename}: {e}")
        traceback.print_exc()
        return video_clip

[stonemason10]

subtitle_config:
font_size: 72
font_weight: "bold"
color: "#FFFF00"
font: "huangkaihuaLawyerfont-2.ttf" #SimHei "KaiTi"
font_path: "E:\ai\font\huangkaihuaLawyerfont-2.ttf"
margin_bottom: 0.25
width_ratio: 0.8
stroke_width: 1
stroke_color: "#000000"
bg_color: None
transparent: True
interline: 4

[stonemason10]

huangkaihuaLawyerfont-2.zip

srt.zip

[GreenJeff1]

I encountered the same issue. Did you find a solution?

[stonemason10]

I have temporarily downgraded the version to 1.0.3

[OsaAjani]

So, this is specifically due to the language your using in your video. From what I understand many languages that use ideograms (at least Chinese, Japanese and Corean, probably a few languages from India and such) dont use spaces.

As an european this is just not something I didn't think about during creation of the TextClip, as I cannot think of any modern european language not using spaces.

Currently the implementation of text clip try to break text lines overflowing from text box, based on spaces. We never cut a word in half, instead we add a breakline in place of the last non overflowing space. Adapting this implementation to work with languages without spacing would be nice, but I absolutely dont now how to do it. Obviously we want the preserve the current system, while supporting an alternative for non-spaced languages. Doing so would probably need to understand the specific rules of such languages, which to my knowledge no current maintainer do. Your welcomed if you want to have a go a it and make a PR.