Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property
lastread
was renamed tolast_read
in #1170 however not all instances were changed. This leads to some cases where only one of the variables is updated. For example, in the case where one callsget_frame
with a frame exactly one ahead of the current position. In this case, onlyself.last_read
is updated, butself.lastread
remains unchanged, leading the two properties to get out of sync.There are third-party projects which relied on the lastread property as it was never declared as private in previous versions (e.g. no underscore prefix). To avoid breaking projects relying on this, we also provide a property with the old name for backwards compatibility.
This should also help maintain the code, as there is already some confusion over the two similarly named properties (#2044).