Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:add some tests for batches #128

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat:add some tests for batches #128

wants to merge 1 commit into from

Conversation

GrapeBaBa
Copy link
Contributor

@GrapeBaBa GrapeBaBa commented May 4, 2023 •
edited
Loading

fix #93

ncitron
ncitron reviewed May 5, 2023
View reviewed changes
src/derive/stages/batches.rs
Arc::new(RwLock::new(state)),
Arc::new(config.clone()),
);
assert!(batches.next().is_none());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be constructing this test to try and get a batch from this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncitron yeah, just draft, will change this assertion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncitron ncitron ncitron left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests: more robust testing for derivation stages
2 participants
@GrapeBaBa @ncitron