Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap models from NVIDIA Modulus. #148

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Wrap models from NVIDIA Modulus. #148

wants to merge 1 commit into from

Conversation

samuelburbulla
Copy link
Collaborator

@samuelburbulla samuelburbulla commented Jul 12, 2024 •
edited
Loading

Feature: Wrap models from NVIDIA Modulus.

Description

Which issue does this PR tackle?

How does it solve the problem?

  • Implements continuiti.wrapper.modulus submodule including FNO class.

How are the changes tested?

  • Added test_modulus_fno.

TODO

  • Testing with nvidia-modulus in CI?

Checklist for Contributors

  • Scope: This PR tackles exactly one problem.
  • Conventions: The branch follows the feature/title-slug convention.
  • Conventions: The PR title follows the Bugfix: Title convention.
  • Coding style: The code passes all pre-commit hooks.
  • Documentation: All changes are well-documented.
  • Tests: New features are tested and all tests pass successfully.
  • Changelog: Updated CHANGELOG.md for new features or breaking changes.
  • Review: A suitable reviewer has been assigned.

Checklist for Reviewers:

  • The PR solves the issue it claims to solve and only this one.
  • Changes are tested sufficiently and all tests pass.
  • Documentation is complete and well-written.
  • Changelog has been updated, if necessary.

@samuelburbulla samuelburbulla force-pushed the feature/modulus-models branch from 81556af to a29fae3 Compare July 12, 2024 15:11
@samuelburbulla samuelburbulla added this to the 0.2 milestone Jul 12, 2024
@samuelburbulla samuelburbulla force-pushed the feature/modulus-models branch from a29fae3 to 0a87a1c Compare July 12, 2024 15:14
@samuelburbulla samuelburbulla force-pushed the feature/modulus-models branch from 0a87a1c to eaad56c Compare July 12, 2024 15:20
@samuelburbulla samuelburbulla changed the title Wrap models from NVIDIA Modulus. [WIP] Wrap models from NVIDIA Modulus. Jul 12, 2024
@samuelburbulla samuelburbulla removed this from the 0.2 milestone Aug 20, 2024
@samuelburbulla samuelburbulla marked this pull request as draft August 20, 2024 12:40
@samuelburbulla samuelburbulla changed the title [WIP] Wrap models from NVIDIA Modulus. Wrap models from NVIDIA Modulus. Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrap operator implementations from modulus
1 participant
@samuelburbulla