Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create abstraction for Cache #189

Closed
AnesBenmerzoug opened this issue Nov 8, 2022 · 2 comments · Fixed by #458
Closed

Create abstraction for Cache #189

AnesBenmerzoug opened this issue Nov 8, 2022 · 2 comments · Fixed by #458
Assignees
Labels
cleanup when code is ugly or unreadable and needs restyling
Milestone

Comments

@AnesBenmerzoug
Copy link
Collaborator

AnesBenmerzoug commented Nov 8, 2022

We should create a proper abstraction of the caching to make the code base cleaner and to allow alternative implementations.

We currently only support Memcached.

This is related to issue #124

@mdbenito mdbenito added the cleanup when code is ugly or unreadable and needs restyling label Nov 18, 2022
@mdbenito
Copy link
Collaborator

mdbenito commented Nov 18, 2022

Additionally, the lifecyle of the cached objects is difficult to understand / opaque. And because we pass cache configs and the memoization decorator connects and holds the client, it is awkward to flush the cache. A trivial stopgap with a neat syntax would be add a property to decorated objects to allow cache flushing.

@AnesBenmerzoug
Copy link
Collaborator Author

Consider writing a notebook about caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup when code is ugly or unreadable and needs restyling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants