From 6446b64c0fb175a46e9d099dc1da5badc5d4d3cf Mon Sep 17 00:00:00 2001 From: Sebastian Wicki Date: Mon, 11 Nov 2024 15:50:22 +0100 Subject: [PATCH] .github: Fix missing variable escaping in LVH command This fixes an issue with the tests-e2e-upgrade workflow where the `${EXTRA{@}}` arguments were actually empty, because commands are bash expanded on the host runner, i.e. before they are passed to the LVH VM. As a result, the additional arguments were ignored. This fix is only applied to v1.15 because other branches use different methods for passing in `cilium connectivity check` command. Signed-off-by: Sebastian Wicki --- .github/workflows/tests-e2e-upgrade.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests-e2e-upgrade.yaml b/.github/workflows/tests-e2e-upgrade.yaml index 2a3b0023456ed..69fd9d8b5e94d 100644 --- a/.github/workflows/tests-e2e-upgrade.yaml +++ b/.github/workflows/tests-e2e-upgrade.yaml @@ -529,7 +529,7 @@ jobs: --sysdump-output-filename "cilium-sysdump-${{ matrix.name }}-" \ --junit-file "cilium-junits/${{ env.job_name }} (${{ join(matrix.*, ', ') }}).xml" \ --junit-property github_job_step="Run tests upgrade 2 (${{ join(matrix.*, ', ') }})" \ - "${EXTRA[@]}" + "\${EXTRA[@]}" # --flush-ct interrupts the flows, so we need to set up again. ./cilium-cli connectivity test --include-conn-disrupt-test --conn-disrupt-test-setup \ @@ -579,7 +579,7 @@ jobs: --sysdump-output-filename "cilium-sysdump-${{ matrix.name }}-" \ --junit-file "cilium-junits/${{ env.job_name }} (${{ join(matrix.*, ', ') }}).xml" \ --junit-property github_job_step="Run tests upgrade 3 (${{ join(matrix.*, ', ') }})" \ - "${EXTRA[@]}" + "\${EXTRA[@]}" - name: Fetch artifacts if: ${{ !success() }}