fix: vm.assume for user address for the Pool Deficit tests & update snapshots (#105)

TepNik · sakulstra · web-flow · commit 4602f2b0d760 · 2025-02-24T17:27:46.000+01:00
Foundry had an issue in regards to storage hotness checks on gas reports.
The changes in the gas reports here highlight the updated snapshots based on the fix.

Co-authored-by: Lukas &lt;lukasstrassel@googlemail.com&gt;
diff --git a/snapshots/Pool.Getters.json b/snapshots/Pool.Getters.json
@@ -4,11 +4,11 @@
   "getLiquidationGracePeriod": "7765",
   "getReserveData": "32157",
   "getUserAccountData: supplies: 0, borrows: 0": "22641",
-  "getUserAccountData: supplies: 0, borrows: 0 with eMode enabled": "7641",
-  "getUserAccountData: supplies: 1, borrows: 0": "35053",
-  "getUserAccountData: supplies: 1, borrows: 0 with eMode enabled": "27360",
-  "getUserAccountData: supplies: 2, borrows: 0": "47575",
-  "getUserAccountData: supplies: 2, borrows: 0 with eMode enabled": "40267",
-  "getUserAccountData: supplies: 2, borrows: 1": "29431",
-  "getUserAccountData: supplies: 2, borrows: 1 with eMode enabled": "30623"
+  "getUserAccountData: supplies: 0, borrows: 0 with eMode enabled": "22641",
+  "getUserAccountData: supplies: 1, borrows: 0": "58553",
+  "getUserAccountData: supplies: 1, borrows: 0 with eMode enabled": "61360",
+  "getUserAccountData: supplies: 2, borrows: 0": "87575",
+  "getUserAccountData: supplies: 2, borrows: 0 with eMode enabled": "90767",
+  "getUserAccountData: supplies: 2, borrows: 1": "118931",
+  "getUserAccountData: supplies: 2, borrows: 1 with eMode enabled": "122123"
 }
diff --git a/snapshots/ProtocolDataProvider.json b/snapshots/ProtocolDataProvider.json
@@ -11,6 +11,6 @@
   "getSiloedBorrowing": "16792",
   "getTotalDebt": "35491",
   "getUnbackedMintCap": "16721",
-  "getUserReserveData": "29607",
+  "getUserReserveData": "72607",
   "getVirtualUnderlyingBalance": "16533"
 }
diff --git a/tests/protocol/pool/Pool.Deficit.sol b/tests/protocol/pool/Pool.Deficit.sol
@@ -279,6 +279,7 @@ contract PoolDeficitTests is TestnetProcedures {
     vm.assume(user != contracts.poolProxy.getReserveAToken(tokenList.usdx));
     vm.assume(user != contracts.poolProxy.getReserveAToken(tokenList.wbtc));
     vm.assume(user != contracts.poolProxy.getReserveAToken(tokenList.weth));
+    vm.assume(user != report.poolConfiguratorProxy);
   }
 
   // we reinvent these helpers on each contract and should move them somewhere common

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,6 @@`
`11`	`11`	`"getSiloedBorrowing": "16792",`
`12`	`12`	`"getTotalDebt": "35491",`
`13`	`13`	`"getUnbackedMintCap": "16721",`
`14`		`- "getUserReserveData": "29607",`
	`14`	`+ "getUserReserveData": "72607",`
`15`	`15`	`"getVirtualUnderlyingBalance": "16533"`
`16`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -279,6 +279,7 @@ contract PoolDeficitTests is TestnetProcedures {`
`279`	`279`	`vm.assume(user != contracts.poolProxy.getReserveAToken(tokenList.usdx));`
`280`	`280`	`vm.assume(user != contracts.poolProxy.getReserveAToken(tokenList.wbtc));`
`281`	`281`	`vm.assume(user != contracts.poolProxy.getReserveAToken(tokenList.weth));`
	`282`	`+ vm.assume(user != report.poolConfiguratorProxy);`
`282`	`283`	`}`
`283`	`284`
`284`	`285`	`// we reinvent these helpers on each contract and should move them somewhere common`