Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add only one value for input_folder in abap_transpile.json #1443

Open
iliyan-velichkov opened this issue Jun 24, 2024 · 3 comments
Open
Assignees

Comments

@iliyan-velichkov
Copy link

iliyan-velichkov commented Jun 24, 2024

The following single value is not supported

{
  "input_folder": "{src/abap}",
  "input_filter": [],
  "output_folder": "dist/abap",
  "libs": [
    {
      "url": "https://github.com/open-abap/open-abap-core"
    },
    {
      "files": "/**/*.*",
      "folder": "/../../../../../root/registry/public/kronos/src/abap"
    }
  ],
  "write_unit_tests": true,
  "write_source_map": true,
  "options": {
    "ignoreSyntaxCheck": false,
    "addFilenames": true,
    "addCommonJS": true,
    "unknownTypes": "runtimeError",
    "skip": []
  }
}
2024-06-24 15:33:32.962 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - > rm -rf output && abap_transpile abap_transpile.json
2024-06-24 15:33:32.962 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - 
2024-06-24 15:33:33.218 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - Transpiler CLI
2024-06-24 15:33:33.219 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - Using config: abap_transpile.json
2024-06-24 15:33:33.219 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - Clone: https://github.com/open-abap/open-abap-core
2024-06-24 15:33:34.698 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - 	515 files added from lib
2024-06-24 15:33:34.954 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - From folder: /../../../../../root/registry/public/kronos/src/abap
2024-06-24 15:33:34.955 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - 	1 files added from lib
2024-06-24 15:33:34.957 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - 0 files added from source
2024-06-24 15:33:34.957 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - 0 files skipped in source
2024-06-24 15:33:34.957 [INFO ] [Thread-1469] [background] o.e.d.c.i.w.service.ActionsService - 

If I change input_folder to {src/abap,test/src} it works

2024-06-24 15:35:30.661 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - > rm -rf output && abap_transpile abap_transpile.json
2024-06-24 15:35:30.661 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - 
2024-06-24 15:35:31.112 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - Transpiler CLI
2024-06-24 15:35:31.113 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - Using config: abap_transpile.json
2024-06-24 15:35:31.113 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - Clone: https://github.com/open-abap/open-abap-core
2024-06-24 15:35:32.428 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - 	515 files added from lib
2024-06-24 15:35:32.474 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - From folder: /../../../../../root/registry/public/kronos/src/abap
2024-06-24 15:35:32.476 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - 	1 files added from lib
2024-06-24 15:35:32.477 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - 1 files added from source
2024-06-24 15:35:32.477 [INFO ] [Thread-1601] [background] o.e.d.c.i.w.service.ActionsService - 0 files skipped in source

Of course I can use just src/abap but I would expect that {src/abap} will work as well.
Also, in my opinion will be better if you use array for specifying more than one value, or use array always.

{
  "input_folder": ["src/abap", "test/src"]
}
@larshp
Copy link
Member

larshp commented Jun 27, 2024

good idea 👍

@larshp
Copy link
Member

larshp commented Sep 26, 2024

#1472

@larshp
Copy link
Member

larshp commented Sep 28, 2024

@iliyan-velichkov try again, latest version

@larshp larshp assigned iliyan-velichkov and unassigned larshp Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants