Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node:sqlite instead of sql.js #1457

Open
MarkTiedemann opened this issue Aug 23, 2024 · 1 comment
Open

Use node:sqlite instead of sql.js #1457

MarkTiedemann opened this issue Aug 23, 2024 · 1 comment

Comments

@MarkTiedemann
Copy link

Since Node 22, there's a built-in node:sqlite module: https://nodejs.org/docs/latest-v22.x/api/sqlite.html

For now, it's experimental and has to be enabled using --experimental-sqlite.

Long term, it might be a good idea to use this module instead of sql.js to remove the dependency (as well as the dependency on WASM).

Not sure whether you are interested in a PR for this yet. If so, I forked and prepared a branch with green CI: main...MarkTiedemann:abaplint-transpiler:sqlite

@larshp
Copy link
Member

larshp commented Aug 24, 2024

Hi,
Thanks, feel free to publish a package

gonna update it to the built-in sometime, but not while its behind experimental flag, what is there now works. I'm not gonna force everyone to change their setups to have the experimental flag, which is probably gonna be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants