Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What works in healthcheck? #106

Open
AnoopAlias opened this issue Feb 15, 2018 · 5 comments
Open

What works in healthcheck? #106

AnoopAlias opened this issue Feb 15, 2018 · 5 comments

Comments

@AnoopAlias
Copy link

@abh - Can you confirm if the health check works in the dev branch.

I see the https://github.com/abh/geodns/blob/dev/dns/hc.example.com.json file, but my tests with "health" label enabled didn't work as expected!.

So can you clarify what works and what not?

@leeweir
Copy link

leeweir commented May 14, 2019

I have tested it, but the health test does not work too. Is there any update? @abh

@abligh
Copy link
Contributor

abligh commented May 16, 2019

I wrote this patch a loooooong time ago. I haven't played with it for a while, and not since it was merged.

Does it pass "go test"? Do you see anything in the logs? Looks like abh@ refactored it a little while ago and maybe something broke. I see this in zones.go:

    // temporary, using this to keep the healthtest code
// compiling and vaguely included
healthChecker bool

which doesn't look good!

@tphil
Copy link

tphil commented Jun 11, 2019

Trying to configure HC, but is not works for some reason as expected. When i am configuring HC on www like tucs, the ping stop to respond at all (even if port 80 is healthy) when i am removing the health: {} it's starting to work. The same thing is happening with tucs. Any advise help?

{
  "serial": 10,
  "ttl": 10,
  "max_hosts": 2,
  "targeting": "country continent @ regiongroup region",
  "data": {
    "": {
      "ns": {
        "ns2.domain.com.": null,
        "ns3.domain.com.": null
      }
    },
    "tucs": {
      "a": [
        [
          "192.168.0.1",
          100
        ],
        [
          "192.168.0.2",
          100
        ]
      ],
      "max_hosts": "1",
      "closest": true,
      "health": {
        "type": "tcp",
        "frequency": 15,
        "retry_time": 5,
        "retries": 2,
        "timeout": 3,
        "port": 80
      }
    }, 
    "www": {
      "a": [
        [
          "192.168.0.1",
          100
        ],
        [
          "192.168.0.2",
          100
        ]
      ],
      "max_hosts": "1",
      "closest": true,
      "health": {
        "type": "tcp",
        "frequency": 15,
        "retry_time": 5,
        "retries": 2,
        "timeout": 3,
        "port": 80
      }
    }
  }
}

@sanqi
Copy link

sanqi commented Jun 15, 2020

Do you have any plans to repair it? @abh

@Gabitzuu
Copy link

Looks like I have a issue with health checks as well. The DNS server doesn't return any record if I have this health object defined:

            "health": {
                "type": "tcp",
                "frequency": 15,
                "retry_time": 5,
                "retries": 2,
                "timeout": 3,
                "port": 25565
            }

@abh some news about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants