You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would you be open to a PR that supports currency conversion? Or do you believe that work should be done outside the LREngine? I didn't see any existing issues discussing the topic already.
One large reason for concern here is that aggregate functions return values in the corporate currency, with no respect for the currency type on either of the records. So this isn't just a problem if parents and children don't match, but anytime the parent has a currency other than the corporate currency.
I think that if LREngine is sending back records that are ready to be updated then currency conversion is best handled inside the engine.
If you're install is configured for multiple currencies, and you have more than one currency installed, then I believe the roll up engine should return the values after converting them to the currency of the destination record.
If you would be open to a PR do you think it would be best to invoke currency conversion when the destination field is currency, or only when the source and destination fields are currency?
Thanks for any feedback!
The text was updated successfully, but these errors were encountered:
Would you be open to a PR that supports currency conversion? Or do you believe that work should be done outside the LREngine? I didn't see any existing issues discussing the topic already.
One large reason for concern here is that aggregate functions return values in the corporate currency, with no respect for the currency type on either of the records. So this isn't just a problem if parents and children don't match, but anytime the parent has a currency other than the corporate currency.
I think that if LREngine is sending back records that are ready to be updated then currency conversion is best handled inside the engine.
If you're install is configured for multiple currencies, and you have more than one currency installed, then I believe the roll up engine should return the values after converting them to the currency of the destination record.
If you would be open to a PR do you think it would be best to invoke currency conversion when the destination field is currency, or only when the source and destination fields are currency?
Thanks for any feedback!
The text was updated successfully, but these errors were encountered: