Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency Support #6

Open
aheber opened this issue Jul 31, 2014 · 1 comment
Open

Currency Support #6

aheber opened this issue Jul 31, 2014 · 1 comment

Comments

@aheber
Copy link
Contributor

aheber commented Jul 31, 2014

Would you be open to a PR that supports currency conversion? Or do you believe that work should be done outside the LREngine? I didn't see any existing issues discussing the topic already.

One large reason for concern here is that aggregate functions return values in the corporate currency, with no respect for the currency type on either of the records. So this isn't just a problem if parents and children don't match, but anytime the parent has a currency other than the corporate currency.

I think that if LREngine is sending back records that are ready to be updated then currency conversion is best handled inside the engine.

If you're install is configured for multiple currencies, and you have more than one currency installed, then I believe the roll up engine should return the values after converting them to the currency of the destination record.

If you would be open to a PR do you think it would be best to invoke currency conversion when the destination field is currency, or only when the source and destination fields are currency?

Thanks for any feedback!

@afawcett
Copy link

I think this can be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants