Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory? throws on non-existing path #4

Open
arichiardi opened this issue Sep 27, 2018 · 1 comment
Open

Directory? throws on non-existing path #4

arichiardi opened this issue Sep 27, 2018 · 1 comment

Comments

@arichiardi
Copy link
Contributor

arichiardi commented Sep 27, 2018 •
edited
Loading

Hi folks, we started to use this lib here and noticed that directory? throws when the path is missing if the underlying implementation throws.

I was wondering whether we should catch and return false instead so that we keep the predicate behavior correct.
@mfikes
Copy link
Contributor

mfikes commented Sep 27, 2018

That seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mfikes @arichiardi