Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkstyle #74

Open
QuintinWillison opened this issue May 24, 2022 · 1 comment
Open

Checkstyle #74

QuintinWillison opened this issue May 24, 2022 · 1 comment
Labels
code-quality Affects the developer experience when working in our codebase.

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented May 24, 2022 •
edited by sync-by-unito bot
Loading

In lieu of #21, the Java code needs some linter love.

┆Issue is synchronized with this Jira Uncategorised by Unito
@ikbalkaya ikbalkaya mentioned this issue May 25, 2022
Merged
@QuintinWillison
Copy link
Contributor Author

To add a little more detail... Lack of lint/static-analysis is causing a lot of noise right now in pull requests and I would prefer to allow reviewers to focus on the stuff that matters, and the machines (CI) to catch the rest.

Currently, checkstyle is explicitly disabled in our POM. I had a quick run, locally, at re-enabling it and the checkstyle:checkstyle report isn't pretty. 😞

Screenshot 2022-05-25 at 16 55 32

Consistent formatting is always nice, but I think I'm more concerned around the lack of static analysis to catch the obvious oversights and/or risks.

@QuintinWillison QuintinWillison mentioned this issue May 26, 2022
Open
@QuintinWillison QuintinWillison added the code-quality Affects the developer experience when working in our codebase. label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Affects the developer experience when working in our codebase.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QuintinWillison