Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcases show strange features #4

Open
jhidding opened this issue Mar 1, 2018 · 1 comment
Open

Testcases show strange features #4

jhidding opened this issue Mar 1, 2018 · 1 comment

Comments

@jhidding
Copy link
Member

jhidding commented Mar 1, 2018

strange feature, documented in testcases 1 and 5: It detects an event at the "edge" of the longitude dimension in event count, i.e. in the Pacific (see notebooks Testcase 1/5 Classification; Testcase 5 shows what I expect to be correct); This also occurs for a number of model grids and variables when scanning with hypercc, example: snw, ACCESS1-0. It seems to prevent a meaningful selection of thresholds because they don't appear in the signal plot, and other plots are empty / full of spurious noise.

strange feature in testcase 5 (for example): spatial edge of the tipping region is detected and counted several times. Should not happen because the spatial edge is below the lower threshold. Varying the upper threshold very slightly leads to abrupt emergence of this bug. Also, detected area is too small in any case. See Testcase 5 Classification for example, compare to Testcase5 which is correct.

@bathiany
Copy link
Contributor

bathiany commented Mar 7, 2018

I think that these are two different (probably unrelated) problems. I update info on the second part of this issue:
The spatial edge of the tipping region is detected and counted several times. I would not expect this to happen because the spatial edge is below the lower threshold. Varying the upper threshold very slightly leads to abrupt emergence of this result. Also, the spatial extent of the detected event around equator is too small.
Comparison between notebooks Testcase5 hypercc and Testcase5 reveals that there may be a bug in the hysteresis thresholding of hypercc? Testcase5.ipynb is correct, the hypercc version gives strange results.
I just uploaded both notebooks with the same parameter settings for comparison via github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants