Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WebSocketClient #286

Open
IvanKvashnin opened this issue Dec 2, 2024 · 27 comments
Open

Support for WebSocketClient #286

IvanKvashnin opened this issue Dec 2, 2024 · 27 comments
Labels
enhancement New feature or request

Comments

@IvanKvashnin
Copy link

Please add websocket/wss client to DSL. For example, jmeter has a good websocket plugin https://jmeter-plugins.org/?search=websocket-samplers.

This will greatly simplify the work !

@SubbotinMXM
Copy link

Upvote!

@makashov73
Copy link

Upvote, it's necessary and useful

@KKoblukov
Copy link

Upvote!

2 similar comments
@kirpikin
Copy link

kirpikin commented Dec 2, 2024

Upvote!

@kamikazanoname
Copy link

Upvote!

@Bis87
Copy link

Bis87 commented Dec 2, 2024

Upvote

@IvanKvashnin
Copy link
Author

Upvote !

@kremlev404
Copy link

Upvote, it's super necessary!

@eldarzaripoff
Copy link

"Upvote !"

@knefedov
Copy link

knefedov commented Dec 2, 2024

Upvote!

4 similar comments
@IanaBlinova
Copy link

Upvote!

@timsay022
Copy link

Upvote!

@ganeles
Copy link

ganeles commented Dec 2, 2024

Upvote!

@vitalKV
Copy link

vitalKV commented Dec 2, 2024

Upvote!

@Kadony
Copy link

Kadony commented Dec 2, 2024

upvote!

@SLomako
Copy link

SLomako commented Dec 2, 2024

Upvote !

@dimayych02
Copy link

upvote

@Harukumo
Copy link

Harukumo commented Dec 3, 2024

Upvote!

@rabelenda
Copy link
Contributor

rabelenda commented Dec 3, 2024

Wow, a lot of suden upvoting in this issue. Do you have any additional insight why is this important for so many people in such short period of time?

There is also this issue which requests the same support .

@rabelenda rabelenda added the enhancement New feature or request label Dec 3, 2024
@IvanKvashnin
Copy link
Author

IvanKvashnin commented Dec 4, 2024

Hi Rebelenda ! Glad you heard us, thank you!
We all came to you from the different Performance tests and QA communities. A lot of guys use Jmeter dsl and we would like to see the ability to test websockets. We know that you can add your script through the DslJavaSample + BaseSampler wrapper. But I would like to see the ability to use a websocket client according to the standard like http. We will be very grateful to you if you implement this.

@chepk
Copy link

chepk commented Dec 4, 2024

Hello @rabelenda!
We are all very interested in this feature.
Resolving this issue would be highly appreciated by the performance testing community

@makashov73
Copy link

Hi, @rabelenda! We will highly appreciate you if you increase the priority of implementing this functionality. This really helpful to build performance testing tools for numerous projects.

@Celenaras
Copy link

Upvote!

@rabelenda
Copy link
Contributor

rabelenda commented Dec 5, 2024

Can you provide different samples (maybe jmx files, potentially scrumbling urls and any potential sensitive config) of the main ways you use the samplers plugin?

I am interested in identifying what are the main/most common scenarios to ease their usage, and also identify the scope (how much features & effort is needed to support most of the use cases).

For example, what samplers do you usually use, what data formats you use for requests, do you usually specify request headers, do you load request bodies from files, do you use binary response assertions or filters?

Do you have any best practices or tips that we should consider in the design?

For example, I see that for handling segmented messages (sent in multiple frames) nowadays with the plugin you need to add a loop or add multiple samplers. Additionally, I see that the sampler does not close the connection by default and reuses it in each thread iteration (which is not the same behavior we use by default in DSL for other connections, like HTTP). In the DSL we could optimize these cases, and other that you may identify, and make them simpler to use in the DSL.

@denisrostov
Copy link

Upvote!

@NaumVik
Copy link

NaumVik commented Dec 13, 2024

Hi @rabelenda, thank you for supporting this issue. Here are the answers to your questions and the simple script example.
As for samplers, the most popular:

  • WS Write
  • WS Read
  • WS Open
  • WS Close
  • WS Ping Pong sampler
  • WS Text Frame Filter

As for loading the body samplers, I load them from the txt files. I don't use the binary response assertion, the simple text Response assertion works for me

Example.zip

@IvanKvashnin
Copy link
Author

Hi @rabelenda, sorry for the long reply. There are some good usage examples here: https://github.com/Luminis-Arnhem/jmeter-websocket-samplers/tree/master/samples

Thx @NaumVik thx for examples !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests