Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcorpus as dependency #13

Open
GoogleCodeExporter opened this issue Mar 16, 2015 · 3 comments
Open

libcorpus as dependency #13

GoogleCodeExporter opened this issue Mar 16, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Pantera includes whole TaKIPI distribution as ‘third-party’ tool. This is 
weird and cumbersome — e.g. when having newer TaKIPI already installed. In 
fact, only libcorpus is used. It'd be far more natural to add libcorpus as 
Pantera's dependency.

Original issue reported on code.google.com by [email protected] on 6 Sep 2010 at 1:51

@GoogleCodeExporter
Copy link
Author

The same for Morfeusz.

Original comment by [email protected] on 7 Sep 2010 at 5:45

@GoogleCodeExporter
Copy link
Author

External Morfeusz can be used with configure option --disable-bundled-morfeusz.

With TaKIPI we planned some changes in the code, that's why it's distributed 
together (at the moment in the SVN you can see some subtle changes in the way 
TaKIPI guesser finds data files).

Original comment by [email protected] on 2 Oct 2010 at 10:46

@GoogleCodeExporter
Copy link
Author

I see two issues with the current approach in Pantera:
 - The libcorpus configure and build process is called from within Pantera's makefile. This is confusing, makes passing options to libcorpus's build system difficult, and seems to be generally the wrong approach.
 - The library is still called libcorpus, with the same version, despite effectively being a fork. This is bound to cause grief should someone e.g. try to compare this tagger with TaKIPI.

I believe you should either push the changes upstream or change the name to 
avoid conflicts if you intend to keep a changed version. Either way, I think 
libcorpus should be built separately, not as a surprise embedded build with 
another configure-like functionality.

Original comment by [email protected] on 6 Oct 2010 at 10:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant