Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PRs to staging and production were not generated #2047

Closed
1 task done
jobara opened this issue Dec 4, 2023 · 6 comments · Fixed by #2072
Closed
1 task done

Release PRs to staging and production were not generated #2047

jobara opened this issue Dec 4, 2023 · 6 comments · Fixed by #2072
Labels
bug Something isn't working
Milestone

Comments

@jobara
Copy link
Collaborator

jobara commented Dec 4, 2023

Prerequisites

Describe the bug

Upon cutting the 1.2.4 release, the sync release GitHub Actions did not trigger and no PRs were generated. I tried to run the "Sync release to staging" action manually but got an error that the "owner" was not defined. There is also a warning that tretuna/sync-branches@v1 is still configured to run on Node v12 but that the action was being forced to run in Node v16.

see:

Expected behavior

Upon a release being generated PRs should automatically be made from the new tag against Staging and Production.

Additional context

This feature was added in #2019

@jobara jobara added the bug Something isn't working label Dec 4, 2023
@jobara jobara added this to the 1.2.5 milestone Dec 4, 2023
@jobara
Copy link
Collaborator Author

jobara commented Dec 5, 2023

tretuna/sync-branches is not seeing much active maintenance at the moment. However, there is a newer release that should be used tretuna/[email protected] to get past the "owner" error mentioned above. However, there is still the deprecation warning for using Node 12. I'm also now running into TreTuna/sync-branches#75 in my local tests so am still not able to run it. There is another issue too with having workflows that are triggered by other automated processes. The solution there is to use a Personal Access Token or Deploy key. See https://stackoverflow.com/questions/69063452/github-actions-on-release-created-workflow-trigger-not-working

@jobara
Copy link
Collaborator Author

jobara commented Dec 11, 2023

Another option is to use GitHub CLI instead of a 3rd party action.

see: https://stackoverflow.com/a/73340290

@jobara
Copy link
Collaborator Author

jobara commented Dec 12, 2023

To further the complication it isn't possible to create PRs from Tags.

See: https://github.com/orgs/community/discussions/23870

@jobara
Copy link
Collaborator Author

jobara commented Dec 12, 2023

To make this fully automated we'd need to also create a branch from the Tag. At the moment there aren't any GitHub CLI commands for performing branch operations. The existing GitHub Actions are few and appear to be out of date or little used. At this point I think it's safer to just manually perform the merge syncing and we can revisit this in the future. For now we should remove the syncing actions as they are not functional.

@jobara
Copy link
Collaborator Author

jobara commented Dec 12, 2023

While investigating this issue, I worked on test implementation at https://github.com/jobara/test-release-sync-actions

@jobara
Copy link
Collaborator Author

jobara commented Dec 12, 2023

New issue to implement the behaviour is filed at #2071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant