You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When trying to merge the v1.5.0 release into staging there were a bunch of merge conflicts which ultimately resulted in bad merge of the package-lock.json file. This failed in GitLab because in the pipeline there it runs npm ci to build which had an error with the package-lock.json file. While this didn't actually fail in CI because there we use npm install instead of npm ci currently.
Describe the solution you'd like
We should update the workflows to use npm ci and also make sure that tests pass before syncinging to GitLab. This way we aren't attempting to deploy broken code.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
Right now there are linting failures in staging, but these are related to changes in eslint and prettier and will need them to be updated for the styling to pass.
Is your feature request related to a problem? Please describe.
When trying to merge the v1.5.0 release into staging there were a bunch of merge conflicts which ultimately resulted in bad merge of the package-lock.json file. This failed in GitLab because in the pipeline there it runs
npm ci
to build which had an error with the package-lock.json file. While this didn't actually fail in CI because there we usenpm install
instead ofnpm ci
currently.Describe the solution you'd like
We should update the workflows to use
npm ci
and also make sure that tests pass before syncinging to GitLab. This way we aren't attempting to deploy broken code.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: