Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sync to branches to deployments if there are CI failures #2357

Open
jobara opened this issue Nov 11, 2024 · 1 comment
Open

Don't sync to branches to deployments if there are CI failures #2357

jobara opened this issue Nov 11, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@jobara
Copy link
Collaborator

jobara commented Nov 11, 2024

Is your feature request related to a problem? Please describe.

When trying to merge the v1.5.0 release into staging there were a bunch of merge conflicts which ultimately resulted in bad merge of the package-lock.json file. This failed in GitLab because in the pipeline there it runs npm ci to build which had an error with the package-lock.json file. While this didn't actually fail in CI because there we use npm install instead of npm ci currently.

Describe the solution you'd like

We should update the workflows to use npm ci and also make sure that tests pass before syncinging to GitLab. This way we aren't attempting to deploy broken code.

Describe alternatives you've considered

No response

Additional context

No response

@jobara jobara added the enhancement New feature or request label Nov 11, 2024
@jobara jobara added this to the 1.6.0 milestone Nov 11, 2024
@jobara
Copy link
Collaborator Author

jobara commented Nov 11, 2024

Right now there are linting failures in staging, but these are related to changes in eslint and prettier and will need them to be updated for the styling to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant