Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally render name of loaded template sample in Loaded Output #32

Open
Vinyl-Davyl opened this issue Mar 22, 2024 · 2 comments
Open

Comments

@Vinyl-Davyl
Copy link
Collaborator

Context

This issue concerns the conditional rendering of the loaded template sample name within the "Loaded Output" section of the Accord Project Playground.

Expected Behavior

Upon clicking a template sample within the playground, the name of the loaded template sample should be clearly displayed within the "Loaded Output" area. This provides users with immediate confirmation of the loaded sample and enhances clarity.

Actual Behavior

Currently, clicking a template sample does not trigger the display of the sample name within the "Loaded Output" section. This leaves the user unsure of which sample is loaded and can be confusing, especially when dealing with multiple samples.

Possible Fix

The potential fix involves modifying the code responsible for rendering the "Loaded Output" section. This could involve:

  • Updating the logic to conditionally render the template sample name based on user interaction (e.g., clicking a sample).
  • Passing the sample name as a parameter to the "Loaded Output" component and conditionally displaying it based on the presence of the name.

Steps to Reproduce

  1. Open the Accord Project Playground.
  2. Navigate to the template library section.
  3. Click on any template sample.
  4. Observe that the name of the clicked sample is not displayed within the "Loaded Output" area.

Existing issues

Your Environment

  • Version used: (Specify the Accord Project Playground version, if applicable)
  • Environment name and version: (e.g., Chrome 110, Node.js 18.12.1)
  • Operating System and version: (e.g., Windows 11, macOS Ventura)
  • Link to your project: (If applicable, provide a link to your local or development environment)

Additional Notes:

@Vinyl-Davyl
Copy link
Collaborator Author

Vinyl-Davyl commented Mar 22, 2024

Solved in PR #33

@Vinyl-Davyl
Copy link
Collaborator Author

Hey 👋 @muskanbararia
I fixed this issue in PR #33 already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant