Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Relations form overridable #1226

Closed
b1rger opened this issue Sep 26, 2024 · 1 comment · Fixed by #1260
Closed

Make Relations form overridable #1226

b1rger opened this issue Sep 26, 2024 · 1 comment · Fixed by #1260

Comments

@b1rger
Copy link
Contributor

b1rger commented Sep 26, 2024

Similar to what we do in generic/views.py
@b1rger
Copy link
Contributor Author

b1rger commented Sep 26, 2024

We are currently using a separate view for the relation form modal, which uses a separate form that sets up the hx-post stuff. It would probably be better to put that code into the generic RelationForm and drop the get_form_class() in the CreateRelationForm view

b1rger added a commit that referenced this issue Oct 3, 2024
@b1rger
refactor(relations): integrate RelationFormHX into RelationForm
a51702f 
This way we don't have to use a separate `get_form_class` in the view
that is uses the form with htmx functionality.

Closes: #1226
@b1rger b1rger mentioned this issue Oct 3, 2024
Merged
b1rger added a commit that referenced this issue Oct 3, 2024
@b1rger
refactor(relations): integrate RelationFormHX into RelationForm
7353e59 
This way we don't have to use a separate `get_form_class` in the view
that is uses the form with htmx functionality.

Closes: #1226
b1rger added a commit that referenced this issue Oct 8, 2024
@b1rger
refactor(relations): integrate RelationFormHX into RelationForm
4df1948 
This way we don't have to use a separate `get_form_class` in the view
that is uses the form with htmx functionality.

Closes: #1226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(relations): integrate RelationFormHX into RelationForm acdh-oeaw/apis-core-rdf
1 participant
@b1rger