Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of static files, styling,... #1240

Open
koeaw opened this issue Sep 30, 2024 · 2 comments
Open

Handling of static files, styling,... #1240

koeaw opened this issue Sep 30, 2024 · 2 comments
Labels
assets Static files, components defining or contributing to appearance

Comments

@koeaw
Copy link
Contributor

koeaw commented Sep 30, 2024

I think we should discuss/decide on how static files or styling more generally,... should be handled now that most of our JS and CSS has been moved out of our templates and into separate files.

Discussion points:

  • file naming scheme
  • where should code go/how should it be split up – relevant for overrideability, reusability
    • if/how to divide up Core code (1 file per app or more, if more: how/when/what),
    • file placement, file order, settings which impact load order (event listeners, defer attribute),
    • blocks (placement) for overrides (external code, external code + Core overrides, custom Core code),
  • custom styling for custom CSS vs. built-in semantic labelling (e.g. "warning", "danger" colours for elements)
@koeaw koeaw added the needs-attention This issue or pull request is in need of discussion, information, assessment by team members label Sep 30, 2024
@koeaw
Copy link
Contributor Author

koeaw commented Oct 1, 2024

Related recent comments re: naming of files #1234 (review), re: template tags #1242 (review)

@sennierer
Copy link
Collaborator

we put all JS in the header and use event listeners and defer to decide when to execute the JS

@sennierer sennierer removed the needs-attention This issue or pull request is in need of discussion, information, assessment by team members label Oct 1, 2024
@koeaw koeaw added the assets Static files, components defining or contributing to appearance label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Static files, components defining or contributing to appearance
Projects
None yet
Development

No branches or pull requests

2 participants