Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(merge): Upon successful merge an error page is shown #1282

Closed
gythaogg opened this issue Oct 11, 2024 · 0 comments · Fixed by #1284 or #1264
Closed

bug(merge): Upon successful merge an error page is shown #1282

gythaogg opened this issue Oct 11, 2024 · 0 comments · Fixed by #1284 or #1264
Assignees
@gythaogg
Labels
bug Something isn't working (properly, as expected, at all)

Comments

@gythaogg
Copy link
Contributor

gythaogg commented Oct 11, 2024 •
edited
Loading

When Enrich view was introduced, 9e8fe5c the get_success_url method of MergeWith got moved from MergeWith into the Enrich view. So, after a successful merge we are directed to an error page (screenshot below).

Both these classes must override the get_successful_url function.

We cannot at the moment test this error directly from the detail page as the Merge links are open (#1278) but we could go to the merge view page by typing the IDs of the two objects we want to merge directly in the URL, for example: https://discworld.acdh-ch-dev.oeaw.ac.at/sample_project.person/merge/5/6

image
@gythaogg gythaogg added the bug Something isn't working (properly, as expected, at all) label Oct 11, 2024
gythaogg added a commit that referenced this issue Oct 11, 2024
@gythaogg
fix(generic): redirect to detail page after merge
c50d9f4 
get_successful_url of MergeWith view got acccidentally removed from
MergeWith in commit 9e8fe5c. This is now reinstated.

Closes #1282
@gythaogg gythaogg mentioned this issue Oct 11, 2024
Merged
@b1rger b1rger closed this as completed in 86d04a3 Oct 14, 2024
@github-actions github-actions bot mentioned this issue Oct 14, 2024
Merged
@github-actions github-actions bot mentioned this issue Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gythaogg gythaogg

Labels
bug Something isn't working (properly, as expected, at all)
Projects
None yet
Milestone
No milestone
2 participants
@b1rger @gythaogg