Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Entities form - location #1285

Closed
gythaogg opened this issue Oct 11, 2024 · 2 comments · Fixed by #1373 or #1411
Closed

Merge Entities form - location #1285

gythaogg opened this issue Oct 11, 2024 · 2 comments · Fixed by #1373 or #1411
Assignees
@b1rger
Labels
UI-UX Appearance, coherence, usability of user-facing parts (frontend, user interface)

Comments

@gythaogg
Copy link
Contributor

At the moment the Merge Entities form in the Edit Entity page appears below the relations table.

Could we have the Merge form along with the entity details on the left panel on the edit view - considering that a successful merge will update the entity fields rather than create relations?

Merge is currently a link in the Actions menu but broken in release 28. Instead of fixing #1278 we could remove the link from this menu and leave the Merge field in a more prominent position.
@gythaogg gythaogg added UI-UX Appearance, coherence, usability of user-facing parts (frontend, user interface) needs-design-decision Requires a decision to be made regarding design/implementation needs-attention This issue or pull request is in need of discussion, information, assessment by team members and removed needs-design-decision Requires a decision to be made regarding design/implementation labels Oct 11, 2024
@gythaogg gythaogg self-assigned this Oct 11, 2024
@b1rger
Copy link
Contributor

b1rger commented Oct 11, 2024

considering that a successful merge will update the entity fields rather than create relations?

It should do both (and did for the old relations). But this has to be implemented, see #1251

@sennierer
Copy link
Collaborator

following #1283
we remove the not needed merge with form from the entities edit view

@sennierer sennierer removed the needs-attention This issue or pull request is in need of discussion, information, assessment by team members label Oct 15, 2024
b1rger added a commit that referenced this issue Nov 13, 2024
@b1rger
fix(apis_entities): remove merge form from the entities edit view
936ebec 
Remove the merge form from the default entities edit view, given that
there is a more powerful merge view that should be used instead.

Closes: #1285
@b1rger b1rger mentioned this issue Nov 13, 2024
Merged
@b1rger b1rger assigned b1rger and unassigned gythaogg Nov 13, 2024
@b1rger b1rger closed this as completed in 2b0dcf1 Nov 18, 2024
This was referenced Nov 18, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b1rger b1rger

Labels
UI-UX Appearance, coherence, usability of user-facing parts (frontend, user interface)
Projects
None yet
Milestone
No milestone
3 participants
@sennierer @b1rger @gythaogg