Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question(apis_entities): should there be a Create option in Merge entities #1365

Closed
gythaogg opened this issue Nov 12, 2024 · 2 comments
Closed
Assignees
Labels
question For any kind of question, whether about usage, contributing or the project in general

Comments

@gythaogg
Copy link
Contributor

Should it be possible to create a brand new entitiy in APIS while attempting to Merge entities?

Kind of related to #1364, and if we want offer this feature, then we should fix #1363

image

@gythaogg gythaogg added the question For any kind of question, whether about usage, contributing or the project in general label Nov 12, 2024
@gythaogg gythaogg changed the title question (apis_entities): should there be a Create option in Merge entities question(apis_entities): should there be a Create option in Merge entities Nov 12, 2024
@b1rger
Copy link
Contributor

b1rger commented Nov 15, 2024

Should it be possible to create a brand new entitiy in APIS while attempting to Merge entities?

I would say no, it should not. It does not really make any sense to first create an instance and then in the same step merge that into another one and delete it again. If the merge form receives a URL as value, it should pass that on to the enrich view.
I created #1396 which changes the default for the autocomplete endpoint to not provide the create option.

@b1rger
Copy link
Contributor

b1rger commented Nov 21, 2024

This Create... option is not part of the merge form anymore since 6995a73, so I'm closing this issue

@b1rger b1rger closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question For any kind of question, whether about usage, contributing or the project in general
Projects
None yet
Development

No branches or pull requests

3 participants