Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge link in action menu broken #1374

Closed
b1rger opened this issue Nov 13, 2024 · 1 comment · Fixed by #1392 or #1393
Closed

Merge link in action menu broken #1374

b1rger opened this issue Nov 13, 2024 · 1 comment · Fixed by #1392 or #1393
Assignees
@b1rger
Labels
bug Something isn't working (properly, as expected, at all)

Comments

@b1rger
Copy link
Contributor

b1rger commented Nov 13, 2024

The merge link was fixed in 0088fc6 by @gythaogg , but this fix was reverted in e01f3f4 during a refactoring. The merge link should point to object.get_merge_view_url instead of object.get_merge_url.
@b1rger b1rger added the bug Something isn't working (properly, as expected, at all) label Nov 13, 2024
@b1rger
Copy link
Contributor Author

b1rger commented Nov 14, 2024

Due to the fact that this is rather urgent, I'm assigning this to me

@b1rger b1rger assigned b1rger and unassigned koeaw Nov 14, 2024
b1rger added a commit that referenced this issue Nov 14, 2024
@b1rger
fix(apis_entities): set target of merge link to correct route
2668fe2 
The merge url was fixed in 0088fc6, but this fix was reverted in e01f3f4
during a "refactoring". This commit sets it back to the correct value.

Closes: #1374
@b1rger b1rger mentioned this issue Nov 14, 2024
Merged
b1rger added a commit that referenced this issue Nov 14, 2024
@b1rger
fix(apis_entities): set target of merge link to correct route
d775b01 
The merge url was fixed in 0088fc6, but this fix was reverted in e01f3f4
during a "refactoring". This commit sets it back to the correct value.

Closes: #1374
b1rger added a commit that referenced this issue Nov 14, 2024
@b1rger
fix(apis_entities): set target of merge link to correct route
5b200ed 
The merge url was fixed in 0088fc6, but this fix was reverted in e01f3f4
during a "refactoring". This commit sets it back to the correct value.

Closes: #1374
This was referenced Nov 14, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b1rger b1rger

Labels
bug Something isn't working (properly, as expected, at all)
Projects
None yet
Milestone
No milestone
2 participants
@b1rger @koeaw