Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateParser: ab and bis in start_date_written and end_date_written #1464

Closed
gythaogg opened this issue Dec 2, 2024 · 2 comments
Closed

DateParser: ab and bis in start_date_written and end_date_written #1464

gythaogg opened this issue Dec 2, 2024 · 2 comments
Labels
question For any kind of question, whether about usage, contributing or the project in general

Comments

@gythaogg
Copy link
Contributor

gythaogg commented Dec 2, 2024

The fields start_date_written and end_date_written are used both at the time of data creation and also when displaying the date fields to the user. For parsing correctly into the start and end date fields, we are using the keywords "ab" and "bis" - which stand out when the rest of the APIS is in English.

How do we get rid of it? I am not a fan of "from" and "to" replacing "ab" and "bis" as they would pose problems when we support multiple languages.

@gythaogg gythaogg added question For any kind of question, whether about usage, contributing or the project in general needs-attention This issue or pull request is in need of discussion, information, assessment by team members needs-design-decision Requires a decision to be made regarding design/implementation labels Dec 2, 2024
@b1rger
Copy link
Contributor

b1rger commented Dec 2, 2024

How do we get rid of it?

I.e. by #1119

@sennierer
Copy link
Collaborator

Can you come up with suggestions on a language independent language that allows to set "around", "before", "after"...
We can use that as a fallback when no parsing function is provided in the field

@gythaogg gythaogg removed needs-attention This issue or pull request is in need of discussion, information, assessment by team members needs-design-decision Requires a decision to be made regarding design/implementation labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question For any kind of question, whether about usage, contributing or the project in general
Projects
None yet
Development

No branches or pull requests

3 participants