Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E53_Place: order of fields for geographic coordinates #1475

Closed
koeaw opened this issue Dec 4, 2024 · 0 comments · Fixed by #1476
Closed

E53_Place: order of fields for geographic coordinates #1475

koeaw opened this issue Dec 4, 2024 · 0 comments · Fixed by #1476
Labels
app-entities Anything to do with entities – the models central to an APIS app UI-UX Appearance, coherence, usability of user-facing parts (frontend, user interface)

Comments

@koeaw
Copy link
Contributor

koeaw commented Dec 4, 2024

I would suggest to reorder the fields for the coordinates for E53_Place:

apis-core-rdf/apis_core/apis_entities/abc.py

Lines 27 to 30 in 10c524e

class E53_Place(models.Model):
label = models.CharField(blank=True, default="", max_length=4096)
longitude = models.FloatField(blank=True, null=True)
latitude = models.FloatField(blank=True, null=True)

because latitude comes before longitude when coordinates are given, so should also be the way in which the fields are presented.

Relevant wherever fields appear in the order in which they are defined in models.py by default.
@koeaw koeaw added UI-UX Appearance, coherence, usability of user-facing parts (frontend, user interface) app-entities Anything to do with entities – the models central to an APIS app labels Dec 4, 2024
koeaw added a commit that referenced this issue Dec 4, 2024
@koeaw
refactor(apis_entities): reorder coordinate fields
8c45663 
Swap `E3_Place` `latitude` and `longitude` fields
so that the fields appear in the order in which
geographic coordinates are given.
Relevant for views/tools which base the default
order of model fields on how they are originally
defined.

Closes: #1475
@koeaw koeaw mentioned this issue Dec 4, 2024
Merged
koeaw added a commit that referenced this issue Dec 4, 2024
@koeaw
refactor(apis_entities): reorder E3_Place coordinate fields
b587a50 
Swap `E3_Place` `latitude` and `longitude` fields
so that the fields appear in the order in which
geographic coordinates are given.
Relevant for views/tools which base the default
order of model fields on how they are originally
defined.

Closes: #1475
b1rger pushed a commit that referenced this issue Dec 4, 2024
@koeaw @b1rger
refactor(apis_entities): reorder E3_Place coordinate fields
d15fe38 
Swap `E3_Place` `latitude` and `longitude` fields
so that the fields appear in the order in which
geographic coordinates are given.
Relevant for views/tools which base the default
order of model fields on how they are originally
defined.

Closes: #1475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app-entities Anything to do with entities – the models central to an APIS app UI-UX Appearance, coherence, usability of user-facing parts (frontend, user interface)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(apis_entities): reorder E3_Place coordinate fields acdh-oeaw/apis-core-rdf
1 participant
@koeaw